Skip to content

completions to use new Jedi get_names method #15791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karthiknadig merged 3 commits into from
Apr 1, 2021
Merged

completions to use new Jedi get_names method #15791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12e1a63
completions to use new Jedi get_names method
moselhy Mar 26, 2021
ff2b2ba
Create 15791.md
moselhy Mar 26, 2021
d446230
Update news/2 Fixes/15791.md
moselhy Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions news/2 Fixes/15791.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
In completions.py: jedi.api.names has been deprecated, switch to new syntax.
(thanks [moselhy](https://github.com/moselhy)).
8 changes: 3 additions & 5 deletions pythonFiles/completion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,11 +581,9 @@ def _process_request(self, request):

if lookup == "names":
return self._serialize_definitions(
jedi.api.names(
source=request.get("source", None),
path=request.get("path", ""),
all_scopes=True,
),
jedi.Script(
source=request.get("source", None), path=request.get("path", "")
).get_names(all_scopes=True),
request["id"],
)

Expand Down