feat: add --fail-hook-affected-tests option to report skipped tests as failed #5519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mark-wiemer
changed the title
Member
|
Hmm, I think we can ignore the CLA issue as the non-signer is AI :D |
5 tasks
Member
|
I'll review this in more detail sometime in the next ~7 days :) |
akshah123
force-pushed
the
claude/fix-issue-4392-011CUfwRYBHqzwYtxQzmsCdN
branch
from
5dee260 to
37acdb2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5519 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 57 57
Lines 4391 4440 +49
Branches 850 861 +11
=======================================
+ Hits 4114 4160 +46
- Misses 277 280 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mark-wiemer
requested changes
Nov 8, 2025
Member
mark-wiemer
left a comment
mark-wiemer
left a comment
There was a problem hiding this comment.
Overall looks OK, just requesting some renames for clarity. I'll check the coverage and make sure I can repro this one locally as it's a big change. Fortunately we should be able to include this in 12.0.0-beta-1 :)
test/integration/fixtures/hooks/before-each-hook-error-with-fail-affected.fixture.js
Outdated
Show resolved
Hide resolved
test/integration/fixtures/hooks/before-each-hook-error-with-fail-affected.fixture.js
Outdated
Show resolved
Hide resolved
test/integration/fixtures/hooks/before-hook-error-with-fail-affected.fixture.js
Outdated
Show resolved
Hide resolved
test/integration/fixtures/hooks/before-each-hook-error-with-fail-affected.fixture.js
Outdated
Show resolved
Hide resolved
test/integration/fixtures/hooks/before-hook-error-with-fail-affected.fixture.js
Outdated
Show resolved
Hide resolved
…s failed When `before()` or `beforeEach()` hooks fail, Mocha currently only reports the hook failure and silently skips affected tests. This makes it difficult to track test coverage and understand the full impact of hook failures. This change introduces a new CLI option `--fail-hook-affected-tests` that, when enabled, reports all tests affected by hook failures as failed instead of silently skipping them. Changes: - Added --fail-hook-affected-tests boolean CLI option - Implemented failAffectedTests() method in Runner to fail all affected tests - Updated hook() method to call failAffectedTests when hooks fail - Added failHookAffectedTests option to Mocha class - Added integration tests for both before() and beforeEach() hook failures - All affected tests now receive descriptive error messages indicating which hook caused them to be skipped Fixes mochajs#4392
- Extract error message creation into createHookSkipError() helper function to eliminate duplication across three locations - Simplify recursive forEach call in failAffectedTests() - Update test fixture and suite descriptions to use backticks for clarity (e.g., 'error in `before` hook')
akshah123
force-pushed
the
claude/fix-issue-4392-011CUfwRYBHqzwYtxQzmsCdN
branch
from
ade4687 to
9fe8493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
before()orbeforeEach()hooks fail, Mocha currently only reports the hook failure and silently skips affected tests. This makes it difficult to track test coverage and understand the full impact of hook failures.This change introduces a new CLI option
--fail-hook-affected-teststhat, when enabled, reports all tests affected by hook failures as failed instead of silently skipping them.Changes:
Fixes #4392
PR Checklist
status: accepting prsOverview