-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update puppeteer to version 22.0.0 #2647
Update puppeteer to version 22.0.0 #2647
Conversation
🦋 Changeset detectedLatest commit: 4cc9064 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I'd love to land this but we'd need to fix the npm registry bit. |
I think this will fix the flakyness with CI so it would be great to land this. |
fd32bb6
to
e39b63a
Compare
@koddsson Thanks for the review! I resolved your comments |
The |
843daa4
to
11a5cea
Compare
11a5cea
to
62ec016
Compare
Just realised that we might have a bunch of docs referencing the |
62ec016
to
e5f0ee8
Compare
e5f0ee8
to
25a8391
Compare
@bashmish I updated the imports in the docs. Additionally, I see the playwright packages are also exporting a devices variable, but I kept those as is to keep the focus of the PR on updating Puppeteer. |
.changeset/curly-snails-rush.md
Outdated
'@web/test-runner-chrome': minor | ||
'@web/dev-server-hmr': minor | ||
'@web/browser-logs': minor | ||
'@web/dev-server': minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to bump only
'@web/test-runner-puppeteer': minor
'@web/test-runner-chrome': minor
?
other packages don't have changes in the API, you only updated the devDependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updatet the changeset 😄
I think it's the very last comment about the versions you need to bump, then we can merge this |
25a8391
to
4cc9064
Compare
@Sanderovich thanks a lot! |
Updated Puppeteer to its latest major. See #2646 for more context