feat(rollup-plugin-html): resolves assets in styles

[bashmish]

What I did

1. rollup-plugin-html resolves assets in styles

[changeset-bot]

🦋 Changeset detected

Latest commit: c3dc21a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@web/rollup-plugin-html	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[bashmish]

does this recursively follow all css files includes (the @import ones)?

if yes, looks like source = Buffer.from(code); would not update anything but the entry point

[thepassle]

The code as currently implemented does not bundle css via @import. I looked at both esbuild and lightningcss, and they have a bundle for css, but it only follows @import, and not url, which is what we need. So for now I only added support for assets referenced via url, afaik you can't add .css files in url. In the future we could consider bundling imported css

[bashmish]

clear, makes sense!

[bashmish]

why do you want to use the allowed extensions list? are there some extensions that should not be handled?

[thepassle]

We're not really sure what people may add in url, so I figured be on the safe side

[bashmish]

with current approach we'll need to maintain a list of extensions and update when new types appear or if we forgot to include smth

instead I'd rather prefer to have a blocklist and make it configurable, we can do that later too

[bashmish]

super nice work Pascal!
I'm just concerned about 2 things

• more about the allowed extensions list
• less about the recursive css imports handling - this one we can also add in the future, but not sure how many need this as css nested imports is not a super nice performance strategy and might not be used much

[thepassle]

@bashmish im gonna go ahead and merge this (it will take some time to end up in our internal npm feed as well, and i'd really like to wrap this up today), the other things we can do in another iteration/separate PR