-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rollup-plugin-html): resolves assets in styles #2664
Merged
thepassle
merged 6 commits into
master
from
feat/rollup-plugin-html-resolves-assets-in-styles
Mar 14, 2024
+582
−11
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a902dda
WIP feat(rollup-plugin-html): resolves assets in styles
bashmish 47728ce
feat: handle font files in css
thepassle 549eaf7
feat: support additional assets in css
thepassle 7cbbccf
chore: prettier on styles
thepassle dd95a78
chore: simplify svg regex
thepassle c3dc21a
Create famous-shoes-joke.md
thepassle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: simplify svg regex
- @web/test-runner-webdriver@0.9.0
- @web/test-runner-visual-regression@0.10.0
- @web/test-runner-saucelabs@0.13.0
- @web/test-runner-saucelabs@0.12.1
- @web/test-runner-saucelabs@0.12.0
- @web/test-runner-saucelabs@0.11.2
- @web/test-runner-puppeteer@0.18.0
- @web/test-runner-puppeteer@0.17.0
- @web/test-runner-module-mocking@0.1.1
- @web/test-runner-junit-reporter@0.8.0
- @web/test-runner-junit-reporter@0.7.2
- @web/test-runner-core@0.13.4
- @web/test-runner-core@0.13.3
- @web/test-runner-core@0.13.2
- @web/test-runner-chrome@0.18.0
- @web/test-runner-chrome@0.17.0
- @web/test-runner-browserstack@0.8.0
- @web/test-runner-browserstack@0.7.2
- @web/test-runner@0.20.0
- @web/test-runner@0.19.0
- @web/test-runner@0.18.3
- @web/test-runner@0.18.2
- @web/storybook-utils@1.1.1
- @web/storybook-utils@1.1.0
- @web/storybook-utils@1.0.2
- @web/storybook-framework-web-components@0.2.0
- @web/storybook-framework-web-components@0.1.3
- @web/storybook-framework-web-components@0.1.2
- @web/storybook-builder@0.2.1
- @web/storybook-builder@0.2.0
- @web/storybook-builder@0.1.21
- @web/storybook-builder@0.1.20
- @web/storybook-builder@0.1.19
- @web/storybook-builder@0.1.18
- @web/storybook-builder@0.1.17
- @web/storybook-builder@0.1.16
- @web/storybook-builder@0.1.15
- @web/storybook-builder@0.1.14
- @web/storybook-builder@0.1.13
- @web/storybook-builder@0.1.12
- @web/storybook-builder@0.1.11
- @web/storybook-builder@0.1.10
- @web/storybook-builder@0.1.9
- @web/storybook-builder@0.1.8
- @web/rollup-plugin-polyfills-loader@2.1.2
- @web/rollup-plugin-html@2.3.0
- @web/rollup-plugin-html@2.2.1
- @web/rollup-plugin-html@2.2.0
- @web/polyfills-loader@2.3.1
- @web/mocks@1.3.1
- @web/mocks@1.3.0
- @web/mocks@1.2.3
- @web/mocks@1.2.2
- @web/mocks@1.2.1
- @web/mocks@1.2.0
- @web/mocks@1.1.2
- @web/dev-server-storybook@2.0.3
- @web/dev-server-storybook@2.0.2
- @web/dev-server-rollup@0.6.4
- @web/dev-server-rollup@0.6.3
- @web/dev-server-rollup@0.6.2
- @web/dev-server-polyfill@1.0.6
- @web/dev-server-polyfill@1.0.5
- @web/dev-server-legacy@2.1.1
- @web/dev-server-import-maps@0.2.1
- @web/dev-server-hmr@0.4.1
- @web/dev-server-esbuild@1.0.4
- @web/dev-server-esbuild@1.0.3
- @web/dev-server-core@0.7.5
- @web/dev-server-core@0.7.4
- @web/dev-server-core@0.7.3
- @web/dev-server-core@0.7.2
- @web/dev-server@0.4.6
- @web/dev-server@0.4.5
- @web/dev-server@0.4.4
- @web/config-loader@0.3.2
- @web/browser-logs@0.4.1
- rollup-plugin-workbox@8.1.2
- rollup-plugin-workbox@8.1.1
commit dd95a7872ebacc1e2b68626f4bf687e0c0f8a5df
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this recursively follow all css files includes (the
@import
ones)?if yes, looks like
source = Buffer.from(code);
would not update anything but the entry pointThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code as currently implemented does not bundle css via
@import
. I looked at both esbuild and lightningcss, and they have abundle
for css, but it only follows@import
, and noturl
, which is what we need. So for now I only added support for assets referenced viaurl
, afaik you can't add .css files inurl
. In the future we could consider bundling imported cssThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clear, makes sense!