feat(rollup-plugin-html): glob patterns exclusion for external assets #2671
Conversation
🦋 Changeset detectedLatest commit: 6207e41 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JulianCataldo
changed the title
There was a problem hiding this comment.
I need this also in #2677 , what are the odds right? :D
PR looks good, I think we just need a few things:
- write a simple unit test
- I'd rename
externaltoexternalAssets, since the whole config is flat andexternalcan refer to anything, so better make it more specific - use currently installed picomatch version
"picomatch": "^2.2.2",(because I see types version mismatch and I think it's more handy to do an upgrade to picomatch 4 alltogether for all deps to prevent potential incompatibilities between different tools in the whole toolchain) - update lock file (I think npm install should have done it, but it wasn't commited?)
can you work on this today-tomorrow? if not, I'd like to work on this myself, since I need this kinda urgently
|
Hey! I agree on your suggestions. If it wasn't for the monorepo setup I would have gave a stab at writing a test too, but I'm a bit lost TBH. If you're familiar with working with this repo., maybe it's better that you continue this PR. Cya |
|
@JulianCataldo I'm familiar indeed, some parts I maintain since recently, this code is new to me, but you did most of it anyway, the rest I can do quickly, so I'll take it from here then. Thanks! |
bashmish
force-pushed
the
feat/support-external-assets-glob-patterns
branch
2 times, most recently
from
3dc76e5 to
3409318
Compare
bashmish
force-pushed
the
feat/support-external-assets-glob-patterns
branch
from
3409318 to
5e4af37
Compare
| const removeLeadingSlash = (str: string) => (str.startsWith('./') ? str.slice(2) : str); | ||
| export function createAssetPicomatchMatcher(glob?: string | string[]) { | ||
| return picomatch(glob || [], { format: removeLeadingSlash }); | ||
| } |
There was a problem hiding this comment.
this was pretty unexpected, but the proposed workaround from the picomatch maintainer seems to be good for us
micromatch/picomatch#77
I added different variations in the test, with and without ./, to be sure it works
| } | ||
|
|
||
| #d2 { | ||
| background-image: url('./image-d.svg'); |
There was a problem hiding this comment.
some deduplication of images was happening, I think because we try to identify images with same hash and merge them into one, so it's a feature of this plugin
but it made testing the exclusion cumbersome, so I added a new image-d.svg/png with the content equal to the file name to get a different hash than for image-a and see in the output all expected exclusions
the deduplication continues to work correctly, it's just that test would be hard to read if I mix so much different functionality in one place
| // picomatch follows glob spec and requires "./" to be removed for the matcher to work | ||
| // it is safe, because with or without it resolves to the same file | ||
| // read more: https://github.com/micromatch/picomatch/issues/77 | ||
| const removeLeadingSlash = (str: string) => (str.startsWith('./') ? str.slice(2) : str); |
There was a problem hiding this comment.
can't we just path.normalize it?
There was a problem hiding this comment.
I wanted to keep modifications to the original paths used in source files to a minimum
path.normalize would solve it too, but might make other unexpected modifications which might influence the matcher behavior
not sure we should use that to be honest
Fixes #811
What I did
Very useful for stuff that already lives in a
publicfolder and are copied as-is.Why?
extractAssetsis all or nothing.transformAssetsdoesn't provide a way to skip an asset.Also related: #2631