Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook-builder): bundle preview assets #2677

Merged

Conversation

bashmish
Copy link
Member

What I did

  1. automatically extract assets from the preview iframe html
  2. bundle assets referenced in the CSS that are included in the preview iframe html

Copy link

changeset-bot bot commented Mar 18, 2024

🦋 Changeset detected

Latest commit: f29dbce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/storybook-builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bashmish bashmish force-pushed the feat/storybook-builder-extract-and-bundle-preview-assets branch from 2fcb405 to 1c93eb2 Compare March 19, 2024 16:03
@bashmish bashmish changed the title feat(storybook-builder): extract and bundle preview assets feat(storybook-builder): bundle preview assets Mar 19, 2024
@bashmish bashmish marked this pull request as ready for review March 19, 2024 16:14
@bashmish bashmish force-pushed the feat/storybook-builder-extract-and-bundle-preview-assets branch from 1c93eb2 to f29dbce Compare March 19, 2024 16:18
@bashmish bashmish merged commit a931ab7 into master Mar 19, 2024
6 of 7 checks passed
@bashmish bashmish deleted the feat/storybook-builder-extract-and-bundle-preview-assets branch March 19, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant