-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-48812 - Match PyMongo TOC #556
DOCSP-48812 - Match PyMongo TOC #556
Conversation
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of questions!
"/fundamentals/connection", | ||
"/fundamentals/crud", | ||
"/usage-examples", | ||
"/fundamentals", | ||
"/fundamentals/serialization", | ||
"/fundamentals/crud/write-operations/update-one", | ||
"/fundamentals/crud/write-operations/update-many", | ||
"/fundamentals/authentication", | ||
"/upgrade", | ||
"/fundamentals/database-collection", | ||
"/get-started" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that some pages here that are landing pages in Pymongo (like Databases and Collections) have been removed as landing pages here. The Databases and Collections page still exists and can be accessed through the URL but not the sidebar. Is that intended and would be fixed when working on the Databases and Collections ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. databases and collections definitely should be viewable; it wasn't because it still had Run a Database Command under it. that page should be (and is now) its own L1.
In PyMongo, many of the L1/landing pages are there only to show usage examples. We're going to be moving the examples to the content pages as part of Comp Coverage, so my thinking was that we could make L1s viewable only if needed (i.e., if they have content other than usage examples to show). Does that work?
@@ -18,7 +19,7 @@ Databases and Collections | |||
:class: singlecol | |||
|
|||
.. toctree:: | |||
/fundamentals/databases-collections/run-command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run a Database command now appears in the sidebar as well as under the Databases and Collections L1. Is that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope! Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR is just for creating the correct TOC structure for CC
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48812
Staging Links
Self-Review Checklist