-
Notifications
You must be signed in to change notification settings - Fork 24
DOCSP-48812 - Match PyMongo TOC #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mongoKart
merged 10 commits into
mongodb:toc-reorg
from
mongoKart:docsp-48812-match-pymongo
Apr 7, 2025
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9a540f7
wip
mongoKart bddfbe6
wip
mongoKart cea4228
edit index
mongoKart 218886a
wip
mongoKart 870fc35
wip
mongoKart a5b4b50
ref drawer
mongoKart f69db28
wip
mongoKart c27d872
small changes
mongoKart 9042203
wip
mongoKart 862f417
mm feedback
mongoKart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that some pages here that are landing pages in Pymongo (like Databases and Collections) have been removed as landing pages here. The Databases and Collections page still exists and can be accessed through the URL but not the sidebar. Is that intended and would be fixed when working on the Databases and Collections ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. databases and collections definitely should be viewable; it wasn't because it still had Run a Database Command under it. that page should be (and is now) its own L1.
In PyMongo, many of the L1/landing pages are there only to show usage examples. We're going to be moving the examples to the content pages as part of Comp Coverage, so my thinking was that we could make L1s viewable only if needed (i.e., if they have content other than usage examples to show). Does that work?