Switch from seleniarm to selenium for arm64 architecture #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The seleniarm fork has now been merged into the main selenium project.
| @@ -106,16 +106,14 @@ function docker-selenium_setup() { | |||
| fi | |||
|
|
|||
| # Only for testing purposes, we are going to introduce basic support for arm64 architecture. | |||
| # Many of the docker images already are multi-arch, but not the selenium ones, that are using | |||
| # a different repository for arm64. Let's use them here. | |||
| # Important note: While we are still running Selenium 3, the arm64 images are using Selenium 4, | |||
| # so they could come with new problems or incompatibilities. | |||
| # As said, this is only for testing purposes, we are not going to support arm64 officially yet. | |||
| # TODO: After testing, consider if we can make this the default for arm64, deleting this conf. | |||
| # and using the seleniarm images when `uname -m` is arm64 or aarch64. | |||
| if [[ -n ${TRY_SELENIARM} ]]; then | |||
There was a problem hiding this comment.
Should we change this stanza to check the archi tecture instead of a var?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The seleniarm fork has now been merged into the main selenium project, so the seleniarm project has been archived and is gradually getting more and more out of date.
This change is just to switch to pulling the images from the main selenium repository since they now support arm64 architecture.
(Also, there's a typo in the name for the firefox image, so I'm not sure anyone else is using this anyway)