Skip to content

Switch from seleniarm to selenium for arm64 architecture #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Switch from seleniarm to selenium for arm64 architecture #141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions runner/main/modules/docker-selenium/docker-selenium.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ function docker-selenium_env() {
SELENIUMURL_9
SELENIUMURL_10

TRY_SELENIARM # Only for testing purposes, decide if we want to try arm64/aarch64 images.
USE_SELVERSION
)
echo "${env[@]}"
Expand Down Expand Up @@ -106,16 +105,13 @@ function docker-selenium_setup() {
fi

# Only for testing purposes, we are going to introduce basic support for arm64 architecture.
# Many of the docker images already are multi-arch, but not the selenium ones, that are using
# a different repository for arm64. Let's use them here.
# Important note: While we are still running Selenium 3, the arm64 images are using Selenium 4,
# so they could come with new problems or incompatibilities.
# As said, this is only for testing purposes, we are not going to support arm64 officially yet.
# TODO: After testing, consider if we can make this the default for arm64, deleting this conf.
# and using the seleniarm images when `uname -m` is arm64 or aarch64.
if [[ -n ${TRY_SELENIARM} ]]; then
chromeimage="seleniarm/standalone-chromium:latest"
firefoximage="sseleniarm/standalone-firefox:latest"
local architecture=
architecture=$(uname -m)
if [[ $architecture == "arm64" ]] || [[ $architecture == "aarch64" ]]; then
chromeimage="selenium/standalone-chromium:latest"
firefoximage="selenium/standalone-firefox:latest"
fi

# And these are the final images and options we will use.
Expand Down