Use score inversion foreground color for engraving elements #30997
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default-colored elements will now use EngravingConfiguration::scoreInversionColor in score colors inversion mode. That’s a light-grey instead of white, which makes it a bit less intense to look at.
8 tasks
Member
Author
|
I'll merge this, because this is how it was probably always supposed to work; if time permits, we'll work on further score color inversion mode tweaks later. |
cbjeukendrup
deleted the
score-inversion-color-for-engraving-elements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default-colored elements will now use EngravingConfiguration::scoreInversionColor in score colors inversion mode. That’s a light-grey instead of white, which makes it a bit less intense to look at.