Updates language-support package type and node version #495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
Running e2e tests in the react-codemirror package fails on main with a message like:
SyntaxError: Named export 'testData' not found. The requested module '@neo4j-cypher/language-support' is a CommonJS module, which may not support all module.exports as named exports.
This testData file is part of the language-support package, and we use an ESModule import to access it in the react-codemirror tests.
The fix:
Adding "type": "module" in the package.json of language-support makes it so .js files (the ones we build with the
build-esm-and-types
script) are treated as ESModule instead of CommonJS.In the
build-commonjs
script the output file is already .cjs instead of .js so this should not interfere with the actual CommonJS file.The node version we were using was also a bit old, and Oskar had suggested updating it, so I shifted it to LTS.