Skip to content

Fixes react-codemirror tests #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fixes react-codemirror tests #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup-and-build/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ runs:
- name: Setup node.js
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22
Copy link
Collaborator Author

@anderson4j anderson4j Apr 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this locally after Oskar's tip, and it does seem to improve flakiness, if not fully fixing it...
Not sure how true this is though, trying to think of a good way to measure it

cache: 'pnpm'
registry-url: 'https://registry.npmjs.org'

Expand Down
1 change: 1 addition & 0 deletions packages/language-support/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"highlighting"
],
"version": "2.0.0-next.20",
"type": "module",
"main": "./dist/cjs/index.cjs",
"module": "./dist/esm/project/language-support/src/index.js",
"types": "./dist/esm/project/language-support/src/index.d.ts",
Expand Down
6 changes: 3 additions & 3 deletions packages/react-codemirror/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
"build": "tsc --declaration --outDir dist/",
"clean": "rm -rf {dist,tsconfig.tsbuildinfo}",
"test": "vitest run",
"test:e2e": "playwright test -c playwright-ct.config.ts",
"test:e2e-ui": "playwright test -c playwright-ct.config.ts --ui",
"test:e2e": "NODE_OPTIONS=--max-old-space-size=8192 playwright test -c playwright-ct.config.ts",
"test:e2e-ui": "NODE_OPTIONS=--max-old-space-size=8192 playwright test -c playwright-ct.config.ts --ui",
"benchmark": "BENCHMARKING=true playwright test -c playwright-ct.config.ts -g \"benchmarking & performance test session\""
},
"repository": {
Expand All @@ -39,7 +39,7 @@
},
"engineStrict": true,
"engines": {
"node": ">=18.18.2"
"node": ">=22.15.0"
},
"dependencies": {
"@codemirror/autocomplete": "^6.17.0",
Expand Down