style: satisfy latest ruff - #78
Merged
Merged
Conversation
The Lint workflow started failing on main after a ruff release tightened its defaults: RUF100 flags the now-unused `# noqa: E402` on the sibling imports, and UP035 wants `collections.abc.Iterable` over the deprecated `typing.Iterable`. Both are ruff --fix autofixes, behaviour-identical: removing a noqa for a non-enabled rule changes nothing, and the Iterable import is a straight relocation. Verified: `ruff check .` -> All checks passed; `ruff format --check .` clean. Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Lint workflow went red on main after a ruff release tightened its default rule set (the run was green on 2026-07-21, red on the next main push). These are the findings the newer ruff reports, fixed at the source:
RUF100— unused# noqa: E402on the sibling imports (removed; E402 is not enabled, so nothing changes)UP035—typing.Iterable→collections.abc.Iterable(fitting for this skill in particular)Verified locally with the exact CI invocation:
ruff check .→ All checks passed;ruff format --check .clean.Note: the root cause is that the shared
skill-repo-skill/validate.ymlrunsuvx ruffunpinned, so ruff's rolling defaults can turn any skill repo's main red on the next push. Worth pinning ruff there fleet-wide — filed separately.