Skip to content

Conversation

@hsmurali
Copy link

@hsmurali hsmurali commented Oct 5, 2024

Made changes to ATACSeqQC.R to handle hg38 and handle errors if it is a custom reference.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/atacseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Oct 5, 2024

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @hsmurali,

It looks like this pull-request is has been made against the latchbio-nfcore/atacseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the latchbio-nfcore/atacseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@hsmurali hsmurali marked this pull request as draft October 5, 2024 04:07
@hsmurali
Copy link
Author

hsmurali commented Oct 5, 2024

@tahirdme Can I get a review?

@JoseEspinosa
Copy link
Member

Hi @hsmurali and thanks for contributing! I don't have very clear what you are doing on this PR would you mind clarifying it. Also, seems that there was a leak on your PR as there are many logs that are included on it. Would you mean cleaning this PR for its review.

@lpantano lpantano changed the base branch from master to dev April 4, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants