Skip to content

Targeted analysis#516

Merged
sateeshperi merged 25 commits intonf-core:devfrom
dcarrillox:511-targeted-analysis
Jun 5, 2025
Merged

Targeted analysis#516
sateeshperi merged 25 commits intonf-core:devfrom
dcarrillox:511-targeted-analysis

Conversation

@dcarrillox
Copy link
Copy Markdown
Contributor

@dcarrillox dcarrillox commented Mar 31, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/methylseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
    • singularity instead of docker
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
    • singularity instead of docker
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Targeted analysis

As outlined in #511, we have introduced additional steps to enhance the analysis of targeted methylation protocols such as the TWIST human methylome panel:

  1. Filtering bedGraph files, to contain only positions listed in a provided BED with target regions.
  2. Running CollectHsMetrics from Picard, to assess the performance of the enrichment. There was Hs metrics #313 already open for this matter.

New Subworkflow and Parameters

To support these updates, we created a new local subworkflow called targeted_sequencing. The following parameters control the targeted analysis:

  • --run_targeted_sequencing (boolean). Instructs the pipeline to perform the targeted analysis, which by default only filters the bedGraph files.
  • --target_regions_file (file path). BED file containing the target regions
  • --run_picard_collecthsmetrics (boolean). Run also CollectHsMetrics using the provided BED file and sample BAM files.

Additional changes

We have also modified some parameters and introduced new ones:

  • --comprehensive parameter:

    • Currently this parameter is available in both bismark and bwameth_methyldackel workflows but behaves differently:
      • In bismark, it merges methylation results regardless of strand (documentation).
      • In bwameth_methyldackel, this parameter does not exist in standalone MethylDackel. In the pipeline's implementation, it enables methylation calling at CHG and CHH contexts.
    • Change: We removed this parameter from the bwameth_methyldackel workflow. In the bismark workflow, we have decoupled --merge_non_CpG from --comprehensive (CG CHG and CHH with --comprehensive flag using bismark workflow #388).
  • New parameters for bwameth workflow:

@dcarrillox dcarrillox added the enhancement New feature or request label Mar 31, 2025
@dcarrillox dcarrillox requested a review from a team as a code owner March 31, 2025 14:14
@dcarrillox dcarrillox requested a review from FelixKrueger March 31, 2025 14:14
"cutadapt": 4.9,
"pigz": 2.8
},
"Workflow": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new tool's version output

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fixed now for the targeted_sequencing part

@sateeshperi sateeshperi linked an issue Jun 2, 2025 that may be closed by this pull request
@nf-core-bot
Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.2.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

Copy link
Copy Markdown
Contributor

@sateeshperi sateeshperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gr8 job with this PR!

@sateeshperi sateeshperi merged commit 3de2912 into nf-core:dev Jun 5, 2025
56 checks passed
@sateeshperi sateeshperi mentioned this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add comprehensive param tests

4 participants