-
Notifications
You must be signed in to change notification settings - Fork 114
Add support for multiple gateways #3275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple gateways #3275
Conversation
8b7192b
to
33a4cb7
Compare
2e13294
to
efd9397
Compare
61c9184
to
896523a
Compare
896523a
to
0ff8cfa
Compare
c1dd270
to
d4dcee1
Compare
d4dcee1
to
c1dd270
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## change/control-data-plane-split #3275 +/- ##
===================================================================
- Coverage 89.74% 86.69% -3.06%
===================================================================
Files 109 125 +16
Lines 11150 14447 +3297
Branches 50 62 +12
===================================================================
+ Hits 10007 12525 +2518
- Misses 1083 1784 +701
- Partials 60 138 +78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work.
I think once we get conformance tests working and we can run our full suite of all tests, we can get a better feeling of any issues that may have arisen.
Thank you for helping me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on the PR, just some small things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, great job! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀
Problem: Users want to be able to configure multiple Gateways with a single installation of NGF. Solution: Support the ability to create multiple Gateways. Routes and policies can be attached to multiple Gateways. Also fixed conformance tests. --------- Co-authored-by: Saylor Berman <s.berman@f5.com>
Proposed changes
Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:
Problem: Users want to be able to configure multiple gateways
Solution: Allows users to configure multiple gateways
Testing:
Manual testing: tracking it here
Closes #3219
Closes #3213
Closes #1443
Closes #2704
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.