This repository was archived by the owner on Mar 5, 2025. It is now read-only.
fix builds without guest module #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI for this is red due to a known issue in Element 1.11.90-RC1. It is also not representative because it includes the guest module. This is a representative CI run that uses the CI definition from this PR, Element 1.11.89, and excludes the guest module, and another to prove it also still works with the guest module. |
mgcm
approved these changes
Jan 10, 2025
weeman1337
force-pushed
the
nic/fix/NIO-64
branch
from
168bacc to
9f68fbe
Compare
The guest module requires the customisations.json with certain settings. The previous condition did not properly remove the file when the guest module was not included in the build. This updated condition actively removes the file and updates the Dockerfile to not fail when it does not exist. Signed-off-by: Kim Brose <[email protected]>
HarHarLinks
force-pushed
the
nic/fix/NIO-64
branch
from
9f68fbe to
457f24d
Compare
mgcm
approved these changes
Jan 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guest module requires the customisations.json with certain settings. The previous condition did not properly remove the file when the guest module was not included in the build: https://github.com/nordeck/element-web-modules/actions/runs/12711712130/job/35435639988#step:25:1215
This updated condition actively removes the file and updates the Dockerfile to not fail when it does not exist: https://github.com/nordeck/element-web-modules/actions/runs/12712355476
✔️ Checklist
Signed-off-byline in the message (more info).