Skip to content

Conversation

@davesnx
Copy link
Contributor

@davesnx davesnx commented Dec 4, 2025

It's been a long debugging session, and the original issue is on ocaml-lsp hovering a type in a reason file it renders as a mix of ocaml syntax and reason syntax, something like:

  let join = String.concat("; ");
/*    ^ 
      list string => string */

Where the arrow was appropriately rendered, but the type wasn't (it should be list(string) => string). Anyway, I finally found that some printer wasn't in place and merlin was probably the problematic.

Not familiar with Merlin, dunno if it needs some testing.

Copy link
Collaborator

@voodoos voodoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks like a reasonable thing to do, thanks !
Can you update the changelog ?

@davesnx
Copy link
Contributor Author

davesnx commented Dec 5, 2025

Sure, done!

@voodoos voodoos merged commit 1468603 into ocaml:main Dec 5, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants