Skip to content

Conversation

@rrahir
Copy link
Collaborator

@rrahir rrahir commented Oct 29, 2025

How to reproduce:
On Firefox,

  • double click the bottom bar to rename a sheet
  • Undo the change (button or through Ctrl-Z)

=> the sheetName is not rolled back to its previous value

The issue seems to lie in the fact that in FF, setting a t-esc on an Element that was previously contenteditable=true creates weird behaviour. I suspect some internal state of the div that is not cleared.

On the other hand, changing the contenteditable state of the span element might not be the best idea and one could consider that it's safer to simply regenerate the span altogether when switching editing state.

This commit takes the last suggested approach.

Task: 5016252

Description:

description of this task, what is implemented and why it is implemented that way.

Task: 5016252

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Oct 29, 2025

Pull request status dashboard

How to reproduce:
On Firefox,
- double click the bottom bar to rename a sheet
- Undo the change (button or through Ctrl-Z)

=> the sheetName is not rolled back to its previous value

The issue seems to lie in the fact that in FF, setting a t-esc on an
Element that was previously `contenteditable=true` creates weird
behaviour. I suspect some internal state of the div that is not cleared.

On the other hand, changing the contenteditable state of the span
element might not be the best idea and one could consider that it's
safer to simply regenerate the span altogether when switching editing
state.

This commit takes the last suggested approach.

Task: 5016252
@rrahir rrahir force-pushed the 17.0-fix-non-updated-sheet-name-rar branch from 46e5d92 to 099cedd Compare November 14, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants