Skip to content

[FIX] reference_type: add single quotes for sheet names with spaces #7409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FIX] reference_type: add single quotes for sheet names with spaces #7409

wants to merge 1 commit into from

Conversation

@rmbh-odoo
Copy link
Contributor

@rmbh-odoo rmbh-odoo commented Nov 6, 2025

Description:

Before this commit:

  • splitReference removed single quotes from sheet names.

After this commit:

  • Applied getCanonicalSymbolName after splitReference to ensure sheet
    Names with spaces keep their quotes.

Task: 5244798

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@rmbh-odoo
[FIX] reference_type: add single quotes for sheet names with spaces
f1b09ed 
Before this commit:
- 'splitReference' removed single quotes from sheet names.

After this commit:
- Applied 'getCanonicalSymbolName' after 'splitReference' to ensure sheet
  Names with spaces keep their quotes.

Task: 5244798
@robodoo
Copy link
Collaborator

robodoo commented Nov 6, 2025

Pull request status dashboard

LucasLefevre
LucasLefevre approved these changes Nov 14, 2025
View reviewed changes
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Nov 14, 2025
@rmbh-odoo
[FIX] reference_type: add single quotes for sheet names with spaces
2a23ddd 
Before this commit:
- 'splitReference' removed single quotes from sheet names.

After this commit:
- Applied 'getCanonicalSymbolName' after 'splitReference' to ensure sheet
  Names with spaces keep their quotes.

closes #7409

Task: 5244798
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
@robodoo robodoo closed this Nov 14, 2025
This was referenced Nov 14, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LucasLefevre LucasLefevre LucasLefevre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rmbh-odoo @robodoo @LucasLefevre