-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find unkeyed #37889
base: main
Are you sure you want to change the base?
Find unkeyed #37889
Conversation
eac4e7f
to
d0d20a8
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
50c48cd
to
cc9f77b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth restricting this to structs with less than X amount of fields? I don't feel like this is a huge problem for a struct with 20 fields, I don't see people doing {true, 1, nil, nil, "0.0.0.0:4317", 3000, false, false, nil}
😄
:) that's probably true, and maybe that would help with the low hanging fruit first. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This implements the check for open-telemetry/opentelemetry-collector#12363
Running this with the opentelemetry-collector repository returns this list: