-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] move api-diff pipeline to ubuntu runner #12549
[chore] move api-diff pipeline to ubuntu runner #12549
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12549 +/- ##
=======================================
Coverage 91.55% 91.55%
=======================================
Files 480 480
Lines 26391 26391
=======================================
Hits 24162 24162
Misses 1766 1766
Partials 463 463 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Signed-off-by: Moritz Wiesinger <[email protected]>
e45fc82
to
5de6746
Compare
Signed-off-by: Moritz Wiesinger <[email protected]>
The workflow is failing in the PR because it still uses the version from main branch I believe. It works on my fork and locally on macOS |
Any way to fix that before merging this PR? |
I don't think so... |
76af795
Description
Move the api-diff workflow to the standard
ubuntu-latest
runner and adjust the OS dependent call to mktemp so that it works for both linux and macos.Link to tracking issue
Fixes #7444
Testing
Tested on my fork:
https://github.com/mowies/opentelemetry-collector/actions/runs/13941800348/job/39019991437
Also tested this locally on MacOS.