Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] move api-diff pipeline to ubuntu runner #12549

Conversation

mowies
Copy link
Member

@mowies mowies commented Mar 4, 2025

Description

Move the api-diff workflow to the standard ubuntu-latest runner and adjust the OS dependent call to mktemp so that it works for both linux and macos.

Link to tracking issue

Fixes #7444

Testing

Tested on my fork:
https://github.com/mowies/opentelemetry-collector/actions/runs/13941800348/job/39019991437

Also tested this locally on MacOS.

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.55%. Comparing base (12dd09f) to head (d6c074f).
Report is 17 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12549   +/-   ##
=======================================
  Coverage   91.55%   91.55%           
=======================================
  Files         480      480           
  Lines       26391    26391           
=======================================
  Hits        24162    24162           
  Misses       1766     1766           
  Partials      463      463           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 19, 2025
@mowies mowies force-pushed the move-api-diff-to-ubuntu-runner branch from e45fc82 to 5de6746 Compare March 19, 2025 08:10
@mowies mowies marked this pull request as ready for review March 19, 2025 08:41
@mowies mowies requested a review from a team as a code owner March 19, 2025 08:41
@mowies mowies requested a review from jpkrohling March 19, 2025 08:41
@mowies
Copy link
Member Author

mowies commented Mar 19, 2025

The workflow is failing in the PR because it still uses the version from main branch I believe. It works on my fork and locally on macOS

@mx-psi
Copy link
Member

mx-psi commented Mar 19, 2025

The workflow is failing in the PR because it still uses the version from main branch I believe. It works on my fork and locally on macOS

Any way to fix that before merging this PR?

@mowies
Copy link
Member Author

mowies commented Mar 19, 2025

I don't think so...

@github-actions github-actions bot removed the Stale label Mar 20, 2025
@mx-psi mx-psi added this pull request to the merge queue Mar 24, 2025
Merged via the queue into open-telemetry:main with commit 76af795 Mar 24, 2025
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Migrate 'Inform Incompatible PRs / Check-Compatibility' check to Ubuntu runner
2 participants