Enable test retry for daily builds #13086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
reviewed
Jan 23, 2025
| @@ -10,19 +10,16 @@ jobs: | |||
| common: | |||
| uses: ./.github/workflows/build-common.yml | |||
| with: | |||
| max-test-retries: 0 | |||
There was a problem hiding this comment.
I would think if we wanted to enable retries we would need to increase this value instead of remove it?
There was a problem hiding this comment.
There was a problem hiding this comment.
thank you for pointing that out
jaydeluca
approved these changes
Jan 23, 2025
trask
reviewed
Jan 23, 2025
.github/workflows/build-common.yml
Outdated
| @@ -290,6 +290,25 @@ jobs: | |||
| if: ${{ !cancelled() && hashFiles('build-scan.txt') != '' }} | |||
| run: cat build-scan.txt | |||
|
|
|||
| - name: Get current job url | |||
| uses: Tiryoh/gha-jobid-action@be260d8673c9211a84cdcf37794ebd654ba81eef # v1.4.0 | |||
There was a problem hiding this comment.
I have security worries about using unpopular external actions, is there another way? would it be ok to just link to the run? https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID
There was a problem hiding this comment.
Replaced that action with a different solution that uses actions/github-script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and collect info about flaky tests into a google sheet.