-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable test retry for daily builds #13086
Changes from 7 commits
dbab955
7bc8830
bd4d68a
a156772
b302fa5
07d4052
ae0a6f1
a8d4f26
4512896
23f6073
b21badf
f7dac2c
79a0354
705a62d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -10,19 +10,16 @@ jobs: | |||||
common: | ||||||
uses: ./.github/workflows/build-common.yml | ||||||
with: | ||||||
max-test-retries: 0 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would think if we wanted to enable retries we would need to increase this value instead of remove it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See opentelemetry-java-instrumentation/conventions/src/main/kotlin/otel.java-conventions.gradle.kts Lines 369 to 370 in edbd9aa
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thank you for pointing that out |
||||||
no-build-cache: true | ||||||
|
||||||
test-latest-deps: | ||||||
uses: ./.github/workflows/reusable-test-latest-deps.yml | ||||||
with: | ||||||
max-test-retries: 0 | ||||||
no-build-cache: true | ||||||
|
||||||
test-indy: | ||||||
uses: ./.github/workflows/reusable-test-indy.yml | ||||||
with: | ||||||
max-test-retries: 0 | ||||||
no-build-cache: true | ||||||
|
||||||
# muzzle is not included here because it doesn't use gradle cache anyway and so is already covered | ||||||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
plugins { | ||
id("otel.java-conventions") | ||
} | ||
|
||
dependencies { | ||
implementation("com.google.api-client:google-api-client:2.7.1") | ||
implementation("com.google.apis:google-api-services-sheets:v4-rev20250106-2.0.0") | ||
implementation("com.google.auth:google-auth-library-oauth2-http:1.30.1") | ||
} | ||
|
||
otelJava { | ||
minJavaVersionSupported.set(JavaVersion.VERSION_17) | ||
} | ||
|
||
tasks { | ||
val reportFlakyTests by registering(JavaExec::class) { | ||
dependsOn(classes) | ||
|
||
mainClass.set("io.opentelemetry.instrumentation.testreport.FlakyTestReporter") | ||
classpath(sourceSets["main"].runtimeClasspath) | ||
|
||
systemProperty("scanPath", project.rootDir) | ||
systemProperty("googleSheetsAccessKey", System.getenv("FLAKY_TEST_REPORTER_ACCESS_KEY")) | ||
systemProperty("buildScanUrl", System.getenv("BUILD_SCAN_URL")) | ||
systemProperty("jobUrl", System.getenv("JOB_URL")) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have security worries about using unpopular external actions, is there another way? would it be ok to just link to the run?
https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced that action with a different solution that uses
actions/github-script