Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OSSF scorecard happy #13179

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Make OSSF scorecard happy #13179

merged 4 commits into from
Feb 4, 2025

Conversation

trask
Copy link
Member

@trask trask commented Feb 3, 2025

This didn't work: #13164

Trying a more conventional setup.

(OSSF scorecard is supposed to look for a successful run of this and then not warn on binary gradle wrappers)

After merging, I'll update the required status checks.

@trask trask requested a review from a team as a code owner February 3, 2025 21:17
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referencing the new workflow is the follow-up work then right?

@trask
Copy link
Member Author

trask commented Feb 3, 2025

Referencing the new workflow is the follow-up work then right?

add reference in https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/.github/repository-settings.md? yeah, I added that in this PR now (and added the required check in the settings)

@trask trask closed this Feb 3, 2025
@trask trask reopened this Feb 3, 2025
@trask
Copy link
Member Author

trask commented Feb 3, 2025

I added that in this PR now (and added the required check in the settings)

nope, I got the name wrong, I think I need to merge this PR first, then I can add the new check as required in the rule set

@trask trask merged commit 8c0b510 into open-telemetry:main Feb 4, 2025
58 checks passed
@trask trask deleted the ossf-gradlew branch February 4, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants