Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove (hopefully) unnecessary workflow lines" #13247

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

trask
Copy link
Member

@trask trask commented Feb 7, 2025

Reverts #13241

It was a good try, but these are needed when calling a reusable workflow, so may as well keep them all for consistency.

Invalid workflow file: .github/workflows/publish-smoke-test-servlet-images.yml#L88
The workflow is not valid. .github/workflows/publish-smoke-test-servlet-images.yml (Line: 88, Col: 3): Error calling workflow 'open-telemetry/opentelemetry-java-instrumentation/.github/workflows/reusable-workflow-notification.yml@1aea455'. The workflow is requesting 'contents: read', but is only allowed 'contents: none'.

this is my understanding of the issue:

  • the non-presence of a permission on the job removes the workflow-level permission (as opposed to being additive)
  • since our repos are public, normally you don't need to specify contents: read anyways
  • when calling reusable workflows though there appears to be some validation that fails if you haven't specified contents: read on the job that is calling the reusable workflow

@trask trask merged commit c03d527 into main Feb 7, 2025
61 checks passed
@trask trask deleted the revert-13241-simplify branch February 7, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants