bugfix: fixing disableprometheusannotation casing

[rivToadd]

Description:

change disableprometheusannotation to lower camel case format

Link to tracking Issue(s):
#2608

• Resolves: observability.metrics.DisablePrometheusAnnotations does not work #2608

Testing:

Documentation:

[Starefossen]

This should be noted as a breaking change (if merged).

[yuriolisa]

@rivToadd, please replace this change from v1alpha1 to v1beta1 and use the conversion.

[pavolloffay]

+1 we cannot merge this in v1alpha1 as it is a breaking change

[jaronoff97]

@pavolloffay IMO this is an acceptable breaking change given the functionality as written will never work as intended. I would prefer we keep this as is to allow v1alpha1 users to use this feature as expected.

[Starefossen]

I am not for nor against the change, but it should be clearly marked in the release notes as a matter of principle. Maybe there should be a versioning policy established for the operator to explain what level of stability users can expect granted the api clearly stays alpha – but so does much within the cloud native ecosystem so at some point one becomes desensitized to the meaning of the word.

[jaronoff97]

@Starefossen this will absolutely be marked as a breaking change, per our changelog guidelines. We do our best to minimize breaking changes despite our alpha status and we're in the midst of moving to a beta status CRD where breaking changes will hopefully be rare. There are features that we put behind featuregates for this purpose too. It would probably be worth defining our guidelines somewhere and we can discuss this at our next SIG meeting.

[jaronoff97]

From the SIG meeting:

• on the topic of this PR
  • what will happen when after making this CR change?
  • if the upper case doesn't work, then this is a bug fix. If not this is a breaking change
  • the base assumption is that we should never making a breaking change in the CRD
  • could we make an upgrade routine to convert from older version to newer version
  • maybe define a second one with the lowercase... (this is what we think should be done)
    • mark the old field deprecated
    • remove all references
    • add a warning for the old field
• For CRDs
  • a breaking change cannot be made without changing the version
  • stability around operator features
    • featureflags exist, but they're not exhaustive and they exist to change behavior not really to opt-in/opt-out
    • we could document it, but it could rot pretty easily...
    • something like kubebuilder struct tags maybe?
  • we don't have stability guarantees currently, we will take this topic async.

[jaronoff97]

you'll need to add this to the v1beta1 type too

[rivToadd]

looks fixed in beta version

[jaronoff97]

per my discussion with @rivToadd, this isn't needed anymore as the fix is in v1beta1 now.