Add replicaset resources by default when using the k8sattributesprocessor #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
iblancasa
changed the title
Signed-off-by: Israel Blancas <[email protected]>
swiatekm
reviewed
Apr 10, 2024
Comment on lines
65
to
69
| { | ||
| APIGroups: []string{"extensions"}, | ||
| Resources: []string{"replicasets"}, | ||
| Verbs: []string{"get", "watch", "list"}, | ||
| }, |
There was a problem hiding this comment.
Why do we need this? I don't think any of our supported K8s versions ship this version.
There was a problem hiding this comment.
When it is not added, the processor doesn't work: #2823, open-telemetry/opentelemetry-collector-contrib#32247
There was a problem hiding this comment.
I mean extensions/replicaset specifically. That API group was removed in K8s 1.16: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#replicaset-v116
There was a problem hiding this comment.
You're right. Let me test if it works without them 🤔
Signed-off-by: Israel Blancas <[email protected]>
swiatekm
approved these changes
Apr 10, 2024
jaronoff97
approved these changes
Apr 10, 2024
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
…ssor (open-telemetry#2832) * Add replicaset resources by default Signed-off-by: Israel Blancas <[email protected]> * Add missing changelog Signed-off-by: Israel Blancas <[email protected]> * Fix changelog Signed-off-by: Israel Blancas <[email protected]> * Remove not needed permissions Signed-off-by: Israel Blancas <[email protected]> --------- Signed-off-by: Israel Blancas <[email protected]>
rubenvp8510
pushed a commit
to rubenvp8510/opentelemetry-operator
that referenced
this pull request
May 7, 2024
…ssor (open-telemetry#2832) * Add replicaset resources by default Signed-off-by: Israel Blancas <[email protected]> * Add missing changelog Signed-off-by: Israel Blancas <[email protected]> * Fix changelog Signed-off-by: Israel Blancas <[email protected]> * Remove not needed permissions Signed-off-by: Israel Blancas <[email protected]> --------- Signed-off-by: Israel Blancas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2823