Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] translate collector/deployment into ja #5900

Merged
merged 10 commits into from
Mar 11, 2025

Conversation

@katzchang katzchang requested a review from a team January 8, 2025 06:39
@katzchang katzchang requested a review from a team as a code owner January 8, 2025 06:39
@opentelemetrybot opentelemetrybot requested a review from a team January 8, 2025 06:40
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Drive-by comment: do not include copies of images (such as content/ja/docs/collector/deployment/gateway/otel-gateway-arch.svg). For details, see Localization > Images.

Also see the errors reported in https://github.com/open-telemetry/opentelemetry.io/actions/runs/12665535073/job/35295361546?pr=5900.

Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @katzchang. I added requests to confirm nuances and consistency for future translation references.

@ymotongpoo ymotongpoo force-pushed the ja-collector-deployment branch from 22768fb to 874a46d Compare February 10, 2025 01:47
@opentelemetrybot opentelemetrybot requested review from a team February 10, 2025 01:48
@ymotongpoo
Copy link
Contributor

@katzchang do you have any updates on this PR?

Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add default_lang_commit

@opentelemetrybot opentelemetrybot requested a review from a team March 3, 2025 06:44
@katzchang
Copy link
Contributor Author

I think I've mostly fixed it, so please review it. @open-telemetry/docs-ja-approvers

@katzchang katzchang requested review from ymotongpoo and chalin March 4, 2025 04:35
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add heading ID for all?

@opentelemetrybot opentelemetrybot requested a review from a team March 5, 2025 08:45
@katzchang katzchang requested a review from ymotongpoo March 5, 2025 08:45
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymotongpoo ymotongpoo added the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Mar 11, 2025
@chalin chalin added this pull request to the merge queue Mar 11, 2025
Merged via the queue into open-telemetry:main with commit 4ba9013 Mar 11, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer lang:ja
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants