Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] translate demo/docker-deployment into ja #6098

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

Msksgm
Copy link
Contributor

@Msksgm Msksgm commented Jan 28, 2025

translated demo/docker-deployment page.

Copy link

linux-foundation-easycla bot commented Jan 28, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@opentelemetrybot opentelemetrybot requested review from a team January 28, 2025 13:17
@Msksgm Msksgm force-pushed the ja/demo/docker-deployment branch 5 times, most recently from f8adbfd to fce6eb1 Compare January 29, 2025 23:41
@Msksgm Msksgm marked this pull request as ready for review January 29, 2025 23:43
@Msksgm Msksgm requested a review from a team as a code owner January 29, 2025 23:43
@Msksgm Msksgm closed this Jan 29, 2025
@Msksgm Msksgm reopened this Jan 29, 2025
@Msksgm Msksgm force-pushed the ja/demo/docker-deployment branch 4 times, most recently from 75d329b to 646aa88 Compare January 31, 2025 22:21
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions, @Msksgm!! Though I left minor comments, overall it looks great!

@opentelemetrybot opentelemetrybot requested a review from a team February 2, 2025 07:51
@Msksgm
Copy link
Contributor Author

Msksgm commented Feb 2, 2025

@ymotongpoo

Thank you for your review.
I've fixed and replied all your review.
Please check it again.

@Msksgm Msksgm force-pushed the ja/demo/docker-deployment branch 2 times, most recently from 272497c to 2a2f5bb Compare February 8, 2025 00:53
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a little bit of translation? Other than that, it looks fine.

@Msksgm Msksgm force-pushed the ja/demo/docker-deployment branch from 2a2f5bb to 1c4e7fc Compare February 10, 2025 05:15
@opentelemetrybot opentelemetrybot requested a review from a team February 10, 2025 05:15
@Msksgm Msksgm force-pushed the ja/demo/docker-deployment branch from 1c4e7fc to f889c66 Compare February 10, 2025 06:18
@ymotongpoo ymotongpoo force-pushed the ja/demo/docker-deployment branch from f889c66 to 5cc4c04 Compare February 11, 2025 07:24
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymotongpoo ymotongpoo added the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Feb 11, 2025
@chalin chalin merged commit 443bf43 into open-telemetry:main Feb 11, 2025
18 checks passed
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey

@Msksgm Msksgm deleted the ja/demo/docker-deployment branch February 11, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer lang:ja
Projects
Development

Successfully merging this pull request may close these issues.

4 participants