[CI] GH check: add file-expired check, and more #6189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
force-pushed
the
chalin-im-npx-vers-2025-02-03
branch
from
6fde4f4 to
3c8de0c
Compare
5 tasks
chalin
force-pushed
the
chalin-im-npx-vers-2025-02-03
branch
from
3c8de0c to
d9d31a4
Compare
|
|
Hmm, not sure that'll work, but we'll see. |
chalin
commented
Feb 3, 2025
Comment on lines
+31
to
44
| env: | ||
| FIX_CMD: fix:dict | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - run: npm run fix:dict | ||
| - run: npm run ${{ env.FIX_CMD }} | ||
| - name: Any changed files? | ||
| run: | | ||
| CHANGES=`git status --porcelain` | ||
| if [[ $CHANGES ]]; then | ||
| echo "Locally run `npm run fix:dict` and commit the changes:" | ||
| echo "Add comment '/fix:${{ env.FIX_CMD }}' to your PR in GitHub," | ||
| echo "or locally run 'npm run ${{ env.FIX_CMD }}' and commit the changes:" | ||
| echo "$CHANGES" | ||
| exit 1 | ||
| else |
There was a problem hiding this comment.
Note to self: might want to define a script so that this can be reused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.github/workflows/check-format.ymlto.github/workflows/check-file.ymlsince the checks are over files, and more than just formatting relatedcheck:expiredas a PR-build check in.github/workflows/check-file.ymlcheck-formatting:PRETTIER_AT_VERSscripts/npx-helper.shscript to be used instead of setting env var likePRETTIER_AT_VERS__check:formatto be more Windows friendsly.@trask can you give this a try under Windows and let me know if this help?