-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] GH check: add file-expired check, and more #6189
Merged
chalin
merged 1 commit into
open-telemetry:main
from
chalin:chalin-im-npx-vers-2025-02-03
Feb 3, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
name: Files | ||
|
||
on: | ||
merge_group: | ||
pull_request: | ||
|
||
jobs: | ||
check-expired: | ||
name: EXPIRED FILE check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- run: npm run check:expired | ||
- run: npm run _diff:fail | ||
|
||
check-filenames: | ||
name: FILENAME check | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- run: npm run check:filenames | ||
|
||
check-formatting: | ||
name: FILE FORMAT | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- run: npm run check:format |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
#!/bin/bash | ||
# | ||
# Runs the given command with npx, ensuring that the version of the | ||
# command/package as declared in `package.json` is first installed. | ||
|
||
if [ $# -eq 0 ]; then | ||
echo "Usage: $0 [--no-ignore-scripts] <npm-command-and-package-name> [args...]" | ||
exit 1 | ||
fi | ||
|
||
npx_vers_from_pkg_json() { | ||
local npm_i_flags="--no-save" | ||
if [[ "$1" == "--no-ignore-scripts" ]]; then | ||
shift | ||
else | ||
npm_i_flags+=" --ignore-scripts" | ||
fi | ||
local command=$1; shift; | ||
# For now we assume that the package name is the same as the command name. | ||
local package=$command | ||
if ! [[ $package =~ ^[a-zA-Z0-9_-]+$ ]]; then | ||
echo "ERROR: Invalid package name '$package'" | ||
exit 1 | ||
fi | ||
local args=$@ | ||
|
||
local version=$(npm pkg get devDependencies.$package | tr -d '^"') | ||
if [[ $version == "{}" ]]; then | ||
echo "ERROR: Could not determine version of '$package' from package.json" | ||
exit 1 | ||
fi | ||
local pkgAtVers="$package@$version" | ||
|
||
if ! npm ls $pkgAtVers; then | ||
(set -x; npm install $npm_i_flags $pkgAtVers) | ||
fi | ||
set -x && npx $pkgAtVers $args | ||
} | ||
|
||
npx_vers_from_pkg_json $@; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: might want to define a script so that this can be reused.