Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] translate "AI Agent Observability - Evolving Standards and Best Practices" blog post #6489

Merged
merged 8 commits into from
Mar 11, 2025

Conversation

ymotongpoo
Copy link
Contributor

@ymotongpoo ymotongpoo commented Mar 7, 2025

@ymotongpoo ymotongpoo requested a review from a team as a code owner March 7, 2025 02:48
@opentelemetrybot opentelemetrybot requested review from a team March 7, 2025 02:48
Copy link
Contributor

@katzchang katzchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ymotongpoo I've made just one comment, and everything else looks fine.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following changes are necessary before this post can be properly displayed in the 2025 folder:

  • Update content/ja/blog/_index.md to match the en page. The hash isn't correct, this page has actually drifted (my bad for that)
  • Add content/ja/blog/2025/ai-agent-observability/index.md

@ymotongpoo
Copy link
Contributor Author

ymotongpoo commented Mar 10, 2025

@katzchang thank you for the review. I updated the point you mentioned. Also if it's good to go, please add docs-approval-missing as well as your approval.

@katzchang katzchang added the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Mar 11, 2025
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, hadn't noticed that i18n / I18N check (pull_request) is failing. You'll need to fix this before I can merged.

Also, the first point of the following has not yet been addressed

@chalin chalin removed the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Mar 11, 2025
@opentelemetrybot opentelemetrybot requested review from a team March 11, 2025 14:52
@chalin chalin force-pushed the blog/ai-agent-observability branch from a43d505 to 9afee53 Compare March 11, 2025 17:01
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once all checks are passing.

Comment on lines +9 to +18
<script>
document.addEventListener("DOMContentLoaded", function () {
if (window.location.pathname.includes('/page/')) return;

var checkbox = document.getElementById("m-blog2025-check");
if (checkbox) checkbox.checked = true;
checkbox = document.getElementById("m-blog2024-check");
if (checkbox) checkbox.checked = true;
});
</script>
Copy link
Contributor

@chalin chalin Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: This JS code doesn't work for the ja site, and probably won't work for other non-en sites.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin chalin added this pull request to the merge queue Mar 11, 2025
Merged via the queue into open-telemetry:main with commit ea3b23c Mar 11, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants