Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] fix drift of content/ja/docs/collector/_index #6507

Conversation

Msksgm
Copy link
Contributor

@Msksgm Msksgm commented Mar 9, 2025

@opentelemetrybot opentelemetrybot requested review from a team March 9, 2025 13:19
@Msksgm Msksgm force-pushed the update-#6172/content/ja/docs/collector/_index.md branch from 26d8248 to aa52486 Compare March 9, 2025 13:20
@Msksgm Msksgm marked this pull request as ready for review March 9, 2025 13:21
@Msksgm Msksgm requested a review from a team as a code owner March 9, 2025 13:21
@Msksgm Msksgm force-pushed the update-#6172/content/ja/docs/collector/_index.md branch from aa52486 to 288c708 Compare March 9, 2025 13:22
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymotongpoo ymotongpoo added the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Mar 10, 2025
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You haven't quite captured the diff:

image

Notice the original line 75 in the above diff has been deleted, but the shortcode call has been left in this PR.

@@ -54,8 +53,13 @@ OpenTelemetryを試したり始めたりするには、バックエンドに直

{{% docs/latest-release collector-releases /%}}

[registry]: /ecosystem/registry/?language=collector
[hosted]: /docs/security/hosting-best-practices/
## ディストリビューションとステータス {#releases}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## ディストリビューションとステータス {#releases}
## 配布とリリース {#releases}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin

Thank you.

I followed your comment and I fixed.

#6507 (review)

However, I did not follow a bellow comment because ディストリビューション is already used in other page like https://opentelemetry.io/ja/docs/collector/distributions/.
Would you telle wheter I have to change my content with other pages or not?

#6507 (comment)

Thank you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin I believe this part is okay with "ディストリビューション" in Japanese. The term "distribution" has different translations based on the context.

@chalin chalin removed the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Mar 11, 2025
@chalin chalin force-pushed the update-#6172/content/ja/docs/collector/_index.md branch from 288c708 to 1989c6a Compare March 11, 2025 13:02
@opentelemetrybot opentelemetrybot requested review from a team March 11, 2025 13:03
@Msksgm Msksgm force-pushed the update-#6172/content/ja/docs/collector/_index.md branch 2 times, most recently from 44cb335 to 409ff18 Compare March 11, 2025 13:37
@Msksgm Msksgm force-pushed the update-#6172/content/ja/docs/collector/_index.md branch from 409ff18 to 0722584 Compare March 11, 2025 13:51
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymotongpoo ymotongpoo added the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Mar 11, 2025
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@chalin chalin added this pull request to the merge queue Mar 11, 2025
Merged via the queue into open-telemetry:main with commit e330a3d Mar 11, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer lang:ja
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants