Remove rpm-vercmp dependency and fix pkg.version_cmp - #782
Merged
Merged
Conversation
vzhestkov
force-pushed
the
openSUSE/fix/3006.0/rpmvercmp
branch
2 times, most recently
from
September 3, 2026 08:17
1656d20 to
cfe8365
Compare
vzhestkov
force-pushed
the
openSUSE/fix/3006.0/rpmvercmp
branch
from
September 3, 2026 09:30
cfe8365 to
29767c8
Compare
vzhestkov
force-pushed
the
openSUSE/fix/3006.0/rpmvercmp
branch
from
September 3, 2026 09:42
29767c8 to
9056291
Compare
vzhestkov
changed the title
m-czernek
approved these changes
Sep 8, 2026
Contributor
|
Adding +1, but we must not forget about the 3008 port (otherwise we'll carry this patch for 3008 as well). |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Backport of: saltstack/salt#68342
+
Part of this PR upstreamed with saltstack/salt#70231
Removes using
rpm-vercmpmodule in favour of moving the logic tosalt.utils.pkg.rpm.This will help to drop an extra module we have to maintain for Salt Bundle
What issues does this PR fix or reference?
Upstream PR: saltstack/salt#68342
Tracks: https://github.com/SUSE/spacewalk/issues/31828
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.