Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xmpp] Improve reconnection logic #14397

Merged
merged 12 commits into from
Aug 19, 2024
Merged

[xmpp] Improve reconnection logic #14397

merged 12 commits into from
Aug 19, 2024

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Feb 15, 2023 •
edited
Loading

  • Improves reconnection logic
  • Improve Thing status handling
  • Add configuration parameter securityMode this enables the user to have TLS required (as default), optional or disabled.
  • Add null annotations

Fixes: #9378
Fixes: #10482
Fixes: #14713

Test jar files:
openHAB 4.2.x: https://1drv.ms/u/s!AnMcxmvEeupwjq5fcNrBW_F-fxnlTA?e=R20Ymo

@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Feb 15, 2023
@wborn wborn added the work in progress A PR that is not yet ready to be merged label Mar 10, 2023
@lsiepel lsiepel mentioned this pull request Jul 30, 2023
Closed
@lsiepel lsiepel marked this pull request as ready for review July 16, 2024 18:29
@lsiepel lsiepel requested a review from pavel-gololobov as a code owner July 16, 2024 18:29
@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed work in progress A PR that is not yet ready to be merged rebuild Triggers Jenkins PR build labels Jul 16, 2024
lsiepel added 2 commits July 16, 2024 20:33
@lsiepel
Fix securityMode
b4cd43d 
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel
Fix SAT
353dcd1 
Signed-off-by: Leo Siepel <[email protected]>
@lsiepel lsiepel requested a review from a team July 16, 2024 19:48
@lsiepel
Copy link
Contributor Author

lsiepel commented Aug 10, 2024

@lolodomo are you able to review?

@lolodomo
Copy link
Contributor

Will do it during next week.

lolodomo
lolodomo requested changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 minor comments

@lsiepel
Fix comments.
4d14bd5 
Signed-off-by: Leo Siepel <[email protected]>
lolodomo
lolodomo approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 31cca5e into openhab:main Aug 19, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.3 milestone Aug 19, 2024
@lsiepel lsiepel deleted the xmpp-reconnect branch August 19, 2024 07:09
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
@lsiepel @digitaldan
[xmpp] Improve reconnection logic (openhab#14397)
e41e674 
* Add null annotations
* Introduce re-connect logic

Signed-off-by: lsiepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
@lsiepel @pgfeller
[xmpp] Improve reconnection logic (openhab#14397)
bd5850d 
* Add null annotations
* Introduce re-connect logic

Signed-off-by: lsiepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@lsiepel @joni1993
[xmpp] Improve reconnection logic (openhab#14397)
a542e09 
* Add null annotations
* Introduce re-connect logic

Signed-off-by: lsiepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@lsiepel @matchews
[xmpp] Improve reconnection logic (openhab#14397)
72bd2c7 
* Add null annotations
* Introduce re-connect logic

Signed-off-by: lsiepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
@skazi0 skazi0 mentioned this pull request Dec 31, 2024
Closed
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
@lsiepel
[xmpp] Improve reconnection logic (openhab#14397)
6a3d779 
* Add null annotations
* Introduce re-connect logic

Signed-off-by: lsiepel <[email protected]>
Signed-off-by: Leo Siepel <[email protected]>
Signed-off-by: Ciprian Pascu <[email protected]>
@lsiepel lsiepel mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@pavel-gololobov pavel-gololobov Awaiting requested review from pavel-gololobov pavel-gololobov is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.3
3 participants
@lsiepel @lolodomo @wborn