8366020: Assert that java code is not executed during the AOT assembly phase

[matias9927]

User code should not be run during the AOT assembly phase and there are already checks in place to assure this. This patch simply adds a debug mode only check. Verified with tier 1-5 tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8366020: Assert that java code is not executed during the AOT assembly phase (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30345/head:pull/30345
$ git checkout pull/30345

Update a local copy of the PR:
$ git checkout pull/30345
$ git pull https://git.openjdk.org/jdk.git pull/30345/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30345

View PR using the GUI difftool:
$ git pr show -t 30345

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30345.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@matias9927 The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bcdd186e)

[vnkozlov]

To avoid confusion may you should use "Java code" instead of "user code" in title and comments.

[vnkozlov]

Use #ifdef ASSERT instead if you guard for debug VM.