Skip to content

8366020: Assert that java code is not executed during the AOT assembly phase #30345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matias9927 wants to merge 2 commits into
base: master
Choose a base branch
from
+15 −0
Open

8366020: Assert that java code is not executed during the AOT assembly phase #30345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2873f72
8366020: Assert that user code is not executed during the AOT assembl…
matias9927 Mar 13, 2026
bcdd186
Merge branch 'master' of github.com:openjdk/jdk into aot_assembly_ass…
matias9927 Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/hotspot/share/cds/aotClassInitializer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,21 @@ bool AOTClassInitializer::can_archive_initialized_mirror(InstanceKlass* ik) {
return false;
}

#ifndef PRODUCT
Copy link
Contributor

@vnkozlov vnkozlov Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use #ifdef ASSERT instead if you guard for debug VM.

if (AOTInitTestClass == nullptr && ArchiveHeapTestClass == nullptr) {
// The above flags (in debug builds only) allow user code to be executed in assembly phase,
// strictly for testing purposes. If these flags are not set, no user code will be executed
// in assembly phase.
if (ik->class_loader() != nullptr && !ik->is_hidden()) {
if (ik->is_interface() && !ik->interface_needs_clinit_execution_as_super()) {
// TODO: why are these interfaces marked as initialized??
} else {
assert(false, "cannot execute user code");
}
}
}
#endif // PRODUCT

// About "static field that may hold a different value" errors:
//
// Automatic selection for aot-inited classes
Expand Down