-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable TLS for Netty4GrpcServerTransport #17406
Enable TLS for Netty4GrpcServerTransport #17406
Conversation
❌ Gradle check result for fddab56: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for a70fd93: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
a70fd93
to
0ac61ba
Compare
❌ Gradle check result for 0ac61ba: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 709cbbb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
709cbbb
to
1135fd6
Compare
❕ Gradle check result for 1135fd6: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17406 +/- ##
============================================
- Coverage 72.40% 72.37% -0.03%
+ Complexity 65828 65786 -42
============================================
Files 5316 5319 +3
Lines 305294 305402 +108
Branches 44289 44299 +10
============================================
- Hits 221033 221029 -4
- Misses 66187 66301 +114
+ Partials 18074 18072 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
❕ Gradle check result for f88e461: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❌ Gradle check result for 675c9a6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 681f228: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for bae5abe: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Switching to getDefault(). Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
…der. Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
691de38
to
13ec303
Compare
❌ Gradle check result for 13ec303: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Finn Carroll <[email protected]>
❌ Gradle check result for caa6605: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Finn Carroll <[email protected]>
❌ Gradle check result for 2309786: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…roviders. Signed-off-by: Finn Carroll <[email protected]>
❌ Gradle check result for ebe3557: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Updated PR description with steps for installing with security plugin companion PR here: opensearch-project/security#5152. I've additionally moved most of the testing for client/cert authentication into this plugin. |
Description
Introduces
SecureNetty4GrpcServerTransport
, a TLS enabled alternative toNetty4GrpcServerTransport
.Mirrors many setting options of the secure http transport, except under the
plugins.security.ssl.aux.
setting prefix.For information on specific settings supported please see the security plugin companion PR:
opensearch-project/security#5152
Building and running the secure transport is a little awkward as security plugin must link with OpenSearch core to build a distribution, which then must be installed into an OpenSearch distribution.
Use the following steps to compile and test this feature branch (darwin-tar used in this example):
Related Issues
Partially resolves #16905
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.