-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use testclusters when testing with security #1414
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1414 +/- ##
============================================
- Coverage 81.62% 81.61% -0.01%
+ Complexity 5870 5864 -6
============================================
Files 533 533
Lines 23669 23669
Branches 2374 2374
============================================
- Hits 19319 19317 -2
- Misses 3190 3193 +3
+ Partials 1160 1159 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Thanks for adding this, it can be done in a follow up PR as well but could you also add a link in our developer guide (https://github.com/opensearch-project/anomaly-detection/blob/main/DEVELOPER_GUIDE.md) that we a can now run integTest with |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Added a new entry to the developer guide on how to run integ tests with security.
Not with this change. This is only for setting up a testcluster for the |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/anomaly-detection/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/anomaly-detection/backport-2.x
# Create a new branch
git switch --create backport/backport-1414-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 03637f1534cea3fa2a6f665fb35cf7b7e52c0e32
# Push it to GitHub
git push --set-upstream origin backport/backport-1414-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/anomaly-detection/backport-2.x Then, create a pull request where the |
* Use testclusters when testing with security Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add download plugin Signed-off-by: Craig Perkins <cwperx@amazon.com> * Get js and security plugin Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add opensearchPlugin Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove duplicate Signed-off-by: Craig Perkins <cwperx@amazon.com> * Wait for yellow Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix tests Signed-off-by: Craig Perkins <cwperx@amazon.com> * Fix bwc test Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add prepareBwcTests Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to developer guide Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
Description
This PR changes the
Test with Security
workflow to use testclusters instead of the docker image. TheintegTest
task in OpenSearch is meant to be run against an opensearch testcluster (example from ISM) and the current workflow ends up spinning up 2 clusters (one testcluster and 1 cluster w/ docker) unnecessarily.Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.