-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding dual cluster arg to gradle run #1441
Conversation
207e5ff
to
da650a6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1441 +/- ##
============================================
- Coverage 81.67% 81.58% -0.09%
+ Complexity 5876 5863 -13
============================================
Files 533 533
Lines 23669 23669
Branches 2374 2374
============================================
- Hits 19331 19310 -21
- Misses 3182 3199 +17
- Partials 1156 1160 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
da650a6
to
32d3e97
Compare
@amitgalitz Can you resolve merge conflicts? |
yes, didn't notice we merged Craig's PR |
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
32d3e97
to
b2e66e2
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/anomaly-detection/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/anomaly-detection/backport-2.x
# Create a new branch
git switch --create backport/backport-1441-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b7af71210b658b05eb30bcb044abd4c70398961f
# Push it to GitHub
git push --set-upstream origin backport/backport-1441-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/anomaly-detection/backport-2.x Then, create a pull request where the |
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Description
Added the ability to run AD locally with 2 clusters, each with there own http and transport ports (9200/9300 and 9201/9301). This allows to easily test cross cluster features.
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.