generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 19
Cleanly handle error states for backend connection issues #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohltyler
commented
Jul 29, 2025
<EuiSpacer size="s" /> | ||
</> | ||
)} | ||
{props.workflow?.ui_metadata?.type === WORKFLOW_TYPE.SEMANTIC_SEARCH_USING_SPARSE_ENCODERS ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no changes on lines 333-387; auto-formatting updated this part.
Verified integ tests pass locally. Failing on CI due to 3.1/3.2 version mismatch, will re-run after merging that PR.
|
1 task
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
jackiehanyang
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the home page UI to cleanly handle scenarios where there are failures to the cluster (most commonly the backend plugin APIs), whether it is a local cluster or external data source (if MDS enabled). Before, there would be ad-hoc toast messages indicating the failures, but no limitation to navigating around the plugin, which could lead to weird side effects (buttons not doing anything, creation failing, etc.) when there was issues executing the plugin APIs. Now, we have blanket messaging on the page to prevent users from triggering these states altogether, and more obvious direction for the users to first fix their cluster before coming back to the UI.
The 2 caught scenarios are:
Scenario 1. Connection issues + MDS disabled: provide wording indicating failures accessing the cluster, and action wording to make sure the cluster has all necessary plugins installed.
Scenario 2. Connection issues + MDS enabled: provide wording indicating failures accessing the cluster, and action wording to make sure the cluster is available and has all necessary features available. Note: there may not be sufficient metadata in the configured data sources to know exactly why some API calls may be failing, so we keep the wording generic. We guide the users by directing them to the data source configuration for further debugging.
All scenarios tested:
Also adds an edge-case NPE check on
models
inQuickConfigureModal
to ensure it is not empty / undefined, which can happen in the case of connection issues to the ML plugin APIs from the backend. In general, this case should not be triggered, unless an intermittent failure. The other changes in this PR already block this from happening, if there is constant/persistent failures to the ML APIs from the connected backend.Screenshots:
Scenario 1

Scenario 2

MDS (local cluster enabled, same behavior as before):

MDS (remote cluster, same behavior as before):

Demo video, toggling between local cluster / remote cluster w/ ML features / remote cluster w/ no ML features:
demo-mds.webm
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.