Fixing unit tests related to mlclient getTask and adding integration test for workflow provisioning under multitenancy #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddhartha Bingi <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1045 +/- ##
=========================================
Coverage 75.53% 75.53%
Complexity 1050 1050
=========================================
Files 101 101
Lines 5215 5215
Branches 498 498
=========================================
Hits 3939 3939
Misses 1038 1038
Partials 238 238 ☔ View full report in Codecov by Sentry. |
siddharthabingi
requested review from
dbwiddis,
owaiskazi19,
joshpalis,
ohltyler,
amitgalitz and
jackiehanyang
as code owners
owaiskazi19
approved these changes
Feb 4, 2025
Signed-off-by: Siddhartha Bingi <[email protected]>
siddharthabingi
changed the title
dbwiddis
reviewed
Feb 4, 2025
src/test/java/org/opensearch/flowframework/rest/RestWorkflowStateTenantAwareIT.java
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/rest/RestWorkflowStateTenantAwareIT.java
Show resolved
Hide resolved
src/test/java/org/opensearch/flowframework/rest/RestWorkflowStateTenantAwareIT.java
Show resolved
Hide resolved
Signed-off-by: Siddhartha Bingi <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
…test for workflow provisioning under multitenancy (#1045) * Fixing unit tests related to mlclient getTask Signed-off-by: Siddhartha Bingi <[email protected]> * Adding integration tests for workflow provisioning under multitenancy Signed-off-by: Siddhartha Bingi <[email protected]> * Addressing comments Signed-off-by: Siddhartha Bingi <[email protected]> --------- Signed-off-by: Siddhartha Bingi <[email protected]> Co-authored-by: Siddhartha Bingi <[email protected]> (cherry picked from commit e18afa6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Feb 4, 2025
…test for workflow provisioning under multitenancy (#1045) * Fixing unit tests related to mlclient getTask Signed-off-by: Siddhartha Bingi <[email protected]> * Adding integration tests for workflow provisioning under multitenancy Signed-off-by: Siddhartha Bingi <[email protected]> * Addressing comments Signed-off-by: Siddhartha Bingi <[email protected]> --------- Signed-off-by: Siddhartha Bingi <[email protected]> Co-authored-by: Siddhartha Bingi <[email protected]> (cherry picked from commit e18afa6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Feb 4, 2025
…ng integration test for workflow provisioning under multitenancy (#1046) Fixing unit tests related to mlclient getTask and adding integration test for workflow provisioning under multitenancy (#1045) * Fixing unit tests related to mlclient getTask * Adding integration tests for workflow provisioning under multitenancy * Addressing comments --------- (cherry picked from commit e18afa6) Signed-off-by: Siddhartha Bingi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddhartha Bingi <[email protected]>
vAdyar
pushed a commit
to vAdyar/flow-framework
that referenced
this pull request
Feb 8, 2025
…test for workflow provisioning under multitenancy (opensearch-project#1045) * Fixing unit tests related to mlclient getTask Signed-off-by: Siddhartha Bingi <[email protected]> * Adding integration tests for workflow provisioning under multitenancy Signed-off-by: Siddhartha Bingi <[email protected]> * Addressing comments Signed-off-by: Siddhartha Bingi <[email protected]> --------- Signed-off-by: Siddhartha Bingi <[email protected]> Co-authored-by: Siddhartha Bingi <[email protected]> Signed-off-by: Vikas Adyar <[email protected]>
joshpalis
pushed a commit
that referenced
this pull request
Feb 10, 2025
* Fixing unit tests related to mlclient getTask and adding integration test for workflow provisioning under multitenancy (#1045) * Fixing unit tests related to mlclient getTask Signed-off-by: Siddhartha Bingi <[email protected]> * Adding integration tests for workflow provisioning under multitenancy Signed-off-by: Siddhartha Bingi <[email protected]> * Addressing comments Signed-off-by: Siddhartha Bingi <[email protected]> --------- Signed-off-by: Siddhartha Bingi <[email protected]> Co-authored-by: Siddhartha Bingi <[email protected]> Signed-off-by: Vikas Adyar <[email protected]> * chore(deps): update aws-actions/configure-aws-credentials action to v4.0.3 (#1029) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Vikas Adyar <[email protected]> * fix(deps): update dependency com.google.code.gson:gson to v2.12.1 (#1035) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Vikas Adyar <[email protected]> * 1050: * Changed the indentation from spaces to tab. * Included private no-args constructors. * refactoring. Signed-off-by: Vikas Adyar <[email protected]> * fix(deps): update dependency software.amazon.cryptography:aws-cryptographic-material-providers to v1.9.0 (#1047) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Vikas Adyar <[email protected]> * chore(deps): update plugin org.gradle.test-retry to v1.6.2 (#1052) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Vikas Adyar <[email protected]> * fix(deps): update dependency org.dafny:dafnyruntime to v4.10.0 (#1053) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Vikas Adyar <[email protected]> * Update template for alert summary with new log pattern tools (#1021) * Update template for alert summary with log pattern Signed-off-by: Sihan He <[email protected]> * Update ChangeLog Signed-off-by: Sihan He <[email protected]> --------- Signed-off-by: Sihan He <[email protected]> Signed-off-by: Vikas Adyar <[email protected]> * JDK 11 compatible changes. Signed-off-by: Vikas Adyar <[email protected]> --------- Signed-off-by: Siddhartha Bingi <[email protected]> Signed-off-by: Vikas Adyar <[email protected]> Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Sihan He <[email protected]> Co-authored-by: Siddhartha Bingi <[email protected]> Co-authored-by: Siddhartha Bingi <[email protected]> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: 000FLMS <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
* Fixing unit tests related to mlclient getTask and adding integration test for workflow provisioning under multitenancy (#1045) * Fixing unit tests related to mlclient getTask Signed-off-by: Siddhartha Bingi <[email protected]> * Adding integration tests for workflow provisioning under multitenancy Signed-off-by: Siddhartha Bingi <[email protected]> * Addressing comments Signed-off-by: Siddhartha Bingi <[email protected]> --------- Signed-off-by: Siddhartha Bingi <[email protected]> Co-authored-by: Siddhartha Bingi <[email protected]> Signed-off-by: Vikas Adyar <[email protected]> * chore(deps): update aws-actions/configure-aws-credentials action to v4.0.3 (#1029) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Vikas Adyar <[email protected]> * fix(deps): update dependency com.google.code.gson:gson to v2.12.1 (#1035) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Vikas Adyar <[email protected]> * 1050: * Changed the indentation from spaces to tab. * Included private no-args constructors. * refactoring. Signed-off-by: Vikas Adyar <[email protected]> * fix(deps): update dependency software.amazon.cryptography:aws-cryptographic-material-providers to v1.9.0 (#1047) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Vikas Adyar <[email protected]> * chore(deps): update plugin org.gradle.test-retry to v1.6.2 (#1052) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Vikas Adyar <[email protected]> * fix(deps): update dependency org.dafny:dafnyruntime to v4.10.0 (#1053) Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Vikas Adyar <[email protected]> * Update template for alert summary with new log pattern tools (#1021) * Update template for alert summary with log pattern Signed-off-by: Sihan He <[email protected]> * Update ChangeLog Signed-off-by: Sihan He <[email protected]> --------- Signed-off-by: Sihan He <[email protected]> Signed-off-by: Vikas Adyar <[email protected]> * JDK 11 compatible changes. Signed-off-by: Vikas Adyar <[email protected]> --------- Signed-off-by: Siddhartha Bingi <[email protected]> Signed-off-by: Vikas Adyar <[email protected]> Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Sihan He <[email protected]> Co-authored-by: Siddhartha Bingi <[email protected]> Co-authored-by: Siddhartha Bingi <[email protected]> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: 000FLMS <[email protected]> (cherry picked from commit 2acbb56) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshpalis
pushed a commit
that referenced
this pull request
Feb 10, 2025
1050: Reduce build warnings. (#1051) * Fixing unit tests related to mlclient getTask and adding integration test for workflow provisioning under multitenancy (#1045) * Fixing unit tests related to mlclient getTask * Adding integration tests for workflow provisioning under multitenancy * Addressing comments --------- * chore(deps): update aws-actions/configure-aws-credentials action to v4.0.3 (#1029) * fix(deps): update dependency com.google.code.gson:gson to v2.12.1 (#1035) * 1050: * Changed the indentation from spaces to tab. * Included private no-args constructors. * refactoring. * fix(deps): update dependency software.amazon.cryptography:aws-cryptographic-material-providers to v1.9.0 (#1047) * chore(deps): update plugin org.gradle.test-retry to v1.6.2 (#1052) * fix(deps): update dependency org.dafny:dafnyruntime to v4.10.0 (#1053) * Update template for alert summary with new log pattern tools (#1021) * Update template for alert summary with log pattern * Update ChangeLog --------- * JDK 11 compatible changes. --------- (cherry picked from commit 2acbb56) Signed-off-by: Siddhartha Bingi <[email protected]> Signed-off-by: Vikas Adyar <[email protected]> Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Sihan He <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Siddhartha Bingi <[email protected]> Co-authored-by: Siddhartha Bingi <[email protected]> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: 000FLMS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
#1025
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.