Adding fast refresh setting during index creation #1074
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Toepker <[email protected]>
toepkerd
force-pushed
the
main
branch
2 times, most recently
from
5455fc2 to
1104d7c
Compare
Signed-off-by: Dennis Toepker <[email protected]>
Signed-off-by: Dennis Toepker <[email protected]>
seankao-az
reviewed
Feb 27, 2025
spark-sql-application/src/main/scala/org/apache/spark/sql/FlintJobExecutor.scala
Outdated
Show resolved
Hide resolved
Signed-off-by: Dennis Toepker <[email protected]>
toepkerd
requested review from
dai-chen,
mengweieric,
penghuo,
anirudha,
kaituo,
YANG-DB,
noCharger,
LantaoJin and
ykmr1224
as code owners
noCharger
reviewed
Feb 27, 2025
| logInfo(s"create $osIndexName") | ||
|
|
||
| using(flintClient.createClient()) { client => | ||
| val request = new CreateIndexRequest(osIndexName) | ||
| request.mapping(mapping, XContentType.JSON) | ||
| request.mapping(mapping, XContentType.JSON).settings(settings, XContentType.JSON) |
There was a problem hiding this comment.
what would happen if settings passed in is None?
There was a problem hiding this comment.
The short answer: a similar thing that would happen if the mapping passed in is None.
This approach closely models after how OS index mappings are passed in during index creation. There is only one caller to OSClient.createIndex : FlintJobExecutor.scala. Similar to index mapping, a fixed index setting string is declared at the top of this file as an effective const. This value is then passed into the OS.createIndex call. As such, the index settings inherits this guarantee from the index mapping approach that the passed in value will not be None.
noCharger
reviewed
Feb 27, 2025
dai-chen
reviewed
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change explicitly sets the
refresh_intervalsetting of an OpenSearch index to 1 second during query results index creation. This makes query results searchable sooner, reducing query latency.Related Issues
List any issues this PR will resolve, e.g. Resolves [...].
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.