Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fast refresh setting during index creation #1074

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+18 −6
Open

Adding fast refresh setting during index creation #1074

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eba04be
Adding fast refresh setting during index creation
toepkerd-zz Feb 26, 2025
e5807a5
abstracting refresh setting outside of OSclient implementation
toepkerd-zz Feb 26, 2025
d20e287
adjusting settings to match that of opensearch index settings
toepkerd-zz Feb 27, 2025
5546a89
addressing comment
toepkerd-zz Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion spark-sql-application/src/main/scala/org/apache/spark/sql/FlintJobExecutor.scala
View file
Original file line number Diff line number Diff line change
@@ -394,7 +394,14 @@ trait FlintJobExecutor {
mapping: String): Either[String, Unit] = {
try {
logInfo(s"create $resultIndex")
osClient.createIndex(resultIndex, mapping)
val fastRefreshSettings =
""" {
| "index": {
| "refresh_interval": "1s"
| }
| }
|""".stripMargin
osClient.createIndex(resultIndex, mapping, fastRefreshSettings)
logInfo(s"create $resultIndex successfully")
Right(())
} catch {
6 changes: 4 additions & 2 deletions spark-sql-application/src/main/scala/org/apache/spark/sql/OSClient.scala
View file
Original file line number Diff line number Diff line change
@@ -61,16 +61,18 @@ class OSClient(val flintOptions: FlintOptions) extends Logging {
* the name of the index
* @param mapping
* the mapping of the index
* @param settings
* * the index settings as a JSON string
* @return
* use Either for representing success or failure. A Right value indicates success, while a
* Left value indicates an error.
*/
def createIndex(osIndexName: String, mapping: String): Unit = {
def createIndex(osIndexName: String, mapping: String, settings: String): Unit = {
logInfo(s"create $osIndexName")

using(flintClient.createClient()) { client =>
val request = new CreateIndexRequest(osIndexName)
request.mapping(mapping, XContentType.JSON)
request.mapping(mapping, XContentType.JSON).settings(settings, XContentType.JSON)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what would happen if settings passed in is None?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The short answer: a similar thing that would happen if the mapping passed in is None.

This approach closely models after how OS index mappings are passed in during index creation. There is only one caller to OSClient.createIndex : FlintJobExecutor.scala. Similar to index mapping, a fixed index setting string is declared at the top of this file as an effective const. This value is then passed into the OS.createIndex call. As such, the index settings inherits this guarantee from the index mapping approach that the passed in value will not be None.


try {
client.createIndex(request, RequestOptions.DEFAULT)