-
Notifications
You must be signed in to change notification settings - Fork 306
Add TLS configuration settings/endpoints for auxiliary transports #5152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add TLS configuration settings/endpoints for auxiliary transports #5152
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5152 +/- ##
==========================================
+ Coverage 71.64% 71.68% +0.04%
==========================================
Files 335 335
Lines 22748 22803 +55
Branches 3599 3607 +8
==========================================
+ Hits 16297 16346 +49
- Misses 4651 4655 +4
- Partials 1800 1802 +2
🚀 New features to boost your workflow:
|
04ba906
to
ab18861
Compare
ab18861
to
5568a3c
Compare
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
…nfigDefine(SECURITY_SSL_HTTP_ENABLED) are the same test. Removing dup. Signed-off-by: Finn Carroll <[email protected]>
…generic helper. Add aux and node-to-node transports. Signed-off-by: Finn Carroll <[email protected]>
…h generic transport helper. Add aux transport case. Signed-off-by: Finn Carroll <[email protected]>
…ing name instead of value. Signed-off-by: Finn Carroll <[email protected]>
…h generic helper. Add aux transport case. Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
… easier application to each CertType. Add aux transport cases. Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
…ider CertType. Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
5568a3c
to
49bcba3
Compare
Signed-off-by: Finn Carroll <[email protected]>
49bcba3
to
2745eda
Compare
Marking this as draft while I revise. We will need a more flexible framework for configuring aux transports in security plugin to support:
|
Description
Add settings for configuring keystore/truststore resources for optional auxiliary client/server transports in OpenSearch core which are supplied and registered by plugins. For more information regarding auxiliary transports see opensearch-project/OpenSearch#16534.
Initially aux transports will only support client-certificate authentication:
https://opensearch.org/docs/latest/security/authentication-backends/client-auth/
Similarly no authorization functionality is included in this PR and is planned for follow up work.
Introduces the following settings for configuring TLS for auxiliary transports:
Enable
Keystore settings
Truststore settings
Issues Resolved
#5104
Do these changes introduce new permission(s) to be displayed in the static dropdown on the front-end? If so, please open a draft PR in the security dashboards plugin and link the draft PR here
Testing
Added tests for SettingsManager and ContextManager for new transport type.
CI will fail due to missing definitions in core since the corresponding PR adding SecureAuxTransportSettingsProvider is still in review.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.