[Followup] fix text function IT for locate and strcmp #3482
+6
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xinyual <[email protected]>
xinyual
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto,
GumpacG,
ykmr1224,
LantaoJin and
noCharger
as code owners
LantaoJin
approved these changes
Mar 26, 2025
LantaoJin
changed the title
LantaoJin
added
testing
7 tasks
dai-chen
approved these changes
Mar 26, 2025
| @@ -243,6 +243,9 @@ static List<RexNode> translateArgument( | |||
| context.rexBuilder.makeLiteral(" "))); | |||
| RTrimArgs.addAll(argList); | |||
| return RTrimArgs; | |||
| case "STRCMP": | |||
| List<RexNode> StrcmpArgs = List.of(argList.get(1), argList.get(0)); | |||
There was a problem hiding this comment.
just wonder why some function's arguments are swapped in this method?
There was a problem hiding this comment.
It's because the order in compareTo between V2 and Calcite is different:
V2:
Integer.compare(str1.stringValue().compareTo(str2.stringValue()), 0)))
Calcite
return (int) Math.signum(s1.compareTo(s0));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix text function IT for locate and strcmp, also, enable nonfallback IT.
All calcite IT pass:
./gradlew :integ-test:integTest --tests '*Calcite*IT'Related Issues
Resolves #3481
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.