Update WKO, WDT and WIT versions #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/buildWLSDockerImage.sh modified: weblogic-azure-aks/src/main/arm/scripts/common.sh modified: weblogic-azure-aks/src/main/arm/scripts/genImageModel.sh
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/buildWLSDockerImage.sh modified: weblogic-azure-aks/src/main/arm/scripts/common.sh modified: weblogic-azure-aks/src/main/arm/scripts/setupWLSDomain.sh
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/setupWLSDomain.sh
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/bicep/modules/_azure-resoruces/_aks.bicep
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/buildWLSDockerImage.sh
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/common.sh
…, 2 node is not enough for wko + wls. Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/createUiDefinition.json
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/buildWLSDockerImage.sh
Signed-off-by: galiacheng <[email protected]> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/setupWLSDomain.sh
edburns
reviewed
Jun 17, 2022
Comment on lines
+120
to
+124
| function download_wdt_wit() { | ||
| local wlsToolingFamilyJsonFile=weblogic_tooling_family.json | ||
| # download the json file that has wls operator version from weblogic-azure repo. | ||
| curl -m ${curlMaxTime} -fsL "${gitUrl4WLSToolingFamilyJsonFile}" -o ${wlsToolingFamilyJsonFile} | ||
| if [ $? -eq 0 ]; then |
There was a problem hiding this comment.
I would like to understand why you are not using the set -Eeuo pipefail best practice in this and other scripts?
edburns
approved these changes
Jun 17, 2022
This was referenced Jun 17, 2022
mriccell
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #159
Dependency: #162
The WLS tooling family versions are stored in
weblogic-azure-aks/src/main/resources/weblogic_tooling_family.json, see #162Note: the pr conflicts with #161, I will resolve it after #161 is merged.